Hacker News new | past | comments | ask | show | jobs | submit login

I would avoid saying anything like "this code is awful". Just say "I can't approve this because X, Y, and Z".



YES! Saying "this code is awful" in a code review is absolutely the wrong approach. What's your expected outcome? For the person who wrote it to say "oh yeah, silly me, I'll rewrite it so it's good"? They probably thought it was good, that's why they submitted it.

Don't make value judgements, point out what's wrong and how it causes problems




Join us for AI Startup School this June 16-17 in San Francisco!

Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: